From 60b9565277fbf2286b6440d59ab897cc554aea12 Mon Sep 17 00:00:00 2001
From: iBug <git@ibugone.com>
Date: Tue, 23 Apr 2024 12:18:07 +0800
Subject: [PATCH] Exclude hidden posts from page__related, fix #4653

---
 CHANGELOG.md                 |  4 ++++
 _includes/page__related.html | 15 +++++++++++++++
 _layouts/single.html         | 23 ++---------------------
 docs/_docs/18-history.md     |  6 +++++-
 4 files changed, 26 insertions(+), 22 deletions(-)
 create mode 100644 _includes/page__related.html

diff --git a/CHANGELOG.md b/CHANGELOG.md
index ebde257b..4a2f5354 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Bug Fixes
+
+- "You may also enjoy" no longer recommends hidden posts. [#4653](https://github.com/mmistakes/minimal-mistakes/issues/4653)
+
 ### Enhancements
 
 - Add Ukrainian translations. [#4273](https://github.com/mmistakes/minimal-mistakes/pull/4273)
diff --git a/_includes/page__related.html b/_includes/page__related.html
new file mode 100644
index 00000000..1b655d6d
--- /dev/null
+++ b/_includes/page__related.html
@@ -0,0 +1,15 @@
+<div class="page__related">
+  {% include before-related.html %}
+  <h2 class="page__related-title">{{ site.data.ui-text[site.locale].related_label | default: "You May Also Enjoy" }}</h2>
+  <div class="grid__wrapper">
+    {% assign count = 0 %}
+    {% assign limit = include.limit | default: 4 %}
+    {% for post in include.posts %}
+      {% if post.hidden %}{% continue %}{% endif %}
+      {% if post.id == page.id %}{% continue %}{% endif %}
+      {% if count >= limit %}{% break %}{% endif %}
+      {% assign count = count | plus: 1 %}
+      {% include archive-single.html type="grid" %}
+    {% endfor %}
+  </div>
+</div>
diff --git a/_layouts/single.html b/_layouts/single.html
index 1f547c75..a5693f32 100644
--- a/_layouts/single.html
+++ b/_layouts/single.html
@@ -70,28 +70,9 @@ layout: default
 
   {% comment %}<!-- only show related on a post page when `related: true` -->{% endcomment %}
   {% if page.id and page.related and site.related_posts.size > 0 %}
-    <div class="page__related">
-      {% include before-related.html %}
-      <h2 class="page__related-title">{{ site.data.ui-text[site.locale].related_label | default: "You May Also Enjoy" }}</h2>
-      <div class="grid__wrapper">
-        {% for post in site.related_posts limit:4 %}
-          {% include archive-single.html type="grid" %}
-        {% endfor %}
-      </div>
-    </div>
+    {% include page__related.html posts=site.related_posts %}
   {% comment %}<!-- otherwise show recent posts if no related when `related: true` -->{% endcomment %}
   {% elsif page.id and page.related %}
-    <div class="page__related">
-      {% include before-related.html %}
-      <h2 class="page__related-title">{{ site.data.ui-text[site.locale].related_label | default: "You May Also Enjoy" }}</h2>
-      <div class="grid__wrapper">
-        {% for post in site.posts limit:4 %}
-          {% if post.id == page.id %}
-            {% continue %}
-          {% endif %}
-          {% include archive-single.html type="grid" %}
-        {% endfor %}
-      </div>
-    </div>
+    {% include page__related.html posts=site.posts %}
   {% endif %}
 </div>
diff --git a/docs/_docs/18-history.md b/docs/_docs/18-history.md
index e79f1478..5cbe6b13 100644
--- a/docs/_docs/18-history.md
+++ b/docs/_docs/18-history.md
@@ -5,7 +5,7 @@ permalink: "/docs/history/"
 excerpt: Change log of enhancements and bug fixes made to the theme.
 sidebar:
   nav: docs
-last_modified_at: '2024-04-23T12:08:54+08:00'
+last_modified_at: '2024-04-23T12:18:03+08:00'
 toc: false
 ---
 
@@ -17,6 +17,10 @@ toc: false
 {% raw %}
 ## Unreleased
 
+### Bug Fixes
+
+- "You may also enjoy" no longer recommends hidden posts. [#4653](https://github.com/mmistakes/minimal-mistakes/issues/4653)
+
 ### Enhancements
 
 - Add Ukrainian translations. [#4273](https://github.com/mmistakes/minimal-mistakes/pull/4273)